Skip to content

Conversation

@tstirrat15
Copy link
Contributor

Description

We had a report that a particular schema structure wasn't working for a user. This adds a test for that structure and fixes the issue.

The tl;dr: is that schema content was being dropped when a previously-encountered import was seen again, because we were returning instead of continueing.

Changes

  • Fix log message
  • Change return to continue
  • Add test and fix test

Testing

Review. See that tests pass

@tstirrat15 tstirrat15 marked this pull request as ready for review January 6, 2026 17:22
@tstirrat15 tstirrat15 requested a review from a team as a code owner January 6, 2026 17:22
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Jan 6, 2026
Copy link
Contributor

@barakmich barakmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay new tests too

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.51%. Comparing base (9e85369) to head (6622ed0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2804      +/-   ##
==========================================
+ Coverage   78.51%   78.51%   +0.01%     
==========================================
  Files         458      458              
  Lines       44253    44253              
==========================================
+ Hits        34741    34743       +2     
- Misses       6693     6695       +2     
+ Partials     2819     2815       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tstirrat15 tstirrat15 added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit 5243b57 Jan 6, 2026
77 of 78 checks passed
@tstirrat15 tstirrat15 deleted the multiple-import-compilation-issue branch January 6, 2026 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants