Change documentation of lookupsubjects cursors #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
previously approved these changes
Jul 1, 2025
vroldanbet
previously approved these changes
Jul 1, 2025
tstirrat15
force-pushed
the
mark-ls-cursors-as-unimplemented
branch
from
50996d8 to
fdce6f0
Compare
|
The latest Buf updates on your PR. Results from workflow Lint / lint (pull_request).
|
vroldanbet
approved these changes
Jul 1, 2025
ecordell
approved these changes
Jul 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of v1.40.1, limits on LookupSubjects are unimplemented and will return an error. This is something that users have tripped on a few times, and because our proto is one of our primary sources of documentation of the gRPC API, I'd like the documentation comments to reflect that. We can revert this change once the API is implemented.
Changes
Testing
Review.