fix: generate unique firebaseToken for web extension #507
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firebase doesn't work in browser extensions, so device.fireToken is always null. Instead of sending null or a placeholder value that could collide, generate a unique token using crypto.randomUUID() prefixed with 'web-ext-'. This prevents unique constraint violations on the firebaseToken field when multiple devices or registration attempts use the same placeholder value. Changes: - Register.tsx: Generate unique token if device.fireToken is null - LoginAwaitingApproval.tsx: Generate unique token if device.fireToken is null The backend firebaseToken field is nullable and has a unique constraint, so this ensures each web extension device gets a unique token without backend changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firebase doesn't work in browser extensions, so device.fireToken is always null. Instead of sending null or a placeholder value that could collide, generate a unique token using crypto.randomUUID() prefixed with 'web-ext-'.
This prevents unique constraint violations on the firebaseToken field when multiple devices or registration attempts use the same placeholder value.
Changes:
The backend firebaseToken field is nullable and has a unique constraint, so this ensures each web extension device gets a unique token without backend changes.