Skip to content

Conversation

@pmathew92
Copy link
Contributor

This PR lets user to be added to a organization while signing up or signing in with a passkey

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@pmathew92 pmathew92 requested a review from a team as a code owner June 24, 2025 05:24
@Widcket
Copy link
Contributor

Widcket commented Jun 24, 2025

FYI the SDK already supports passing arbitrary parameters to any request: https://github.com/auth0/Auth0.Android/blob/3.8.0/auth0/src/main/java/com/auth0/android/request/Request.kt#L57
This is why none of the other methods in the Authentication API client support an explicit "organization" argument.

@Widcket
Copy link
Contributor

Widcket commented Jun 24, 2025

If you prefer to add an explicit argument for this, consider adding the argument to all the other (relevant) methods of the Authentication API client.

@pmathew92
Copy link
Contributor Author

pmathew92 commented Jun 24, 2025

If you prefer to add an explicit argument for this, consider adding the argument to all the other (relevant) methods of the Authentication API client.

The idea was to explicitly say that a user can be added to an org while signing up and signing in with passkeys. Hence added to only these two api end points. I am aware ,we can add it as an additional parameter to the request object, but felt this would be more clearer with the intention. If that is not required, there is no additional changes required on SDKs and we just needs to call this out in the docs

@Widcket
Copy link
Contributor

Widcket commented Jun 24, 2025

I am aware ,we can add it as an additional parameter to the request object but felt this would be more clearer with the intention.

Sounds good 👍🏼

NandanPrabhu
NandanPrabhu previously approved these changes Jun 26, 2025
* ```
*
* @param realm the connection to use. If excluded, the application will use the default connection configured in the tenant
* @return a request to configure and start that will yield [PasskeyChallenge]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc comments should mention the new argument here as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was accidentally missed. Updated the same

@pmathew92 pmathew92 merged commit 3dfa352 into main Jun 29, 2025
7 checks passed
@pmathew92 pmathew92 deleted the SDK-6124 branch June 29, 2025 18:11
@pmathew92 pmathew92 mentioned this pull request Jul 2, 2025
@pmathew92 pmathew92 mentioned this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants