-
Notifications
You must be signed in to change notification settings - Fork 165
Support Process Death in WebAuthProvider #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Process Death in WebAuthProvider #784
Conversation
|
@ahibrahimleague Thank you for raising this PR. Will review this and check if we can include this in any of our coming releases |
|
Hello @pmathew92, have you had the chance to look into this? wondering about the outcome. |
|
Hi @ahibrahimleague Apologies for the delay, will plan to merge this with the next Android release |
|
Hi @ahibrahimleague , |
|
@pmathew92 I fixed the lint issue, also please find the before and after videos: Before auth0_reproducer_no_fix.mp4After auth0_with_fix.mp4 |
|
Hi @ahibrahimleague , I have approved the PR . We require all commits to be signed before we can merge them. Could you please sign your commits ? Once signed, I will merge this for our next release |
e4d1db9 to
c4c52ac
Compare
98166b1 to
7423543
Compare
7423543 to
e35891d
Compare
|
@pmathew92 I had to do a rebase and force push to be able to sign the commits. Can you please approve the workflow, once it passes, approve the PR itself? Thanks! |
Changes
This PR fixes issue #779, where Auth0 fails to invoke the registered callbacks due to losing the callbacks that were registered when calling
await()orstart().This was achieved by serializing the Auth0Manager state into JSON and saving this JSON into the
AuthorizationActivitybundle. When restoration happens, we rebuild the Auth0Manager again from the already saved bundle.In order though to receive the callbacks from the newly restored OAuthManager, we need to listen to the callbacks through an application-scoped callback, so I've added a couple of new APIs called
addCallbackandremoveCallback(open for naming and redesign changes) that clients if interested, they can call add/removeCallback from onStart and onStop, so that when the oauth authentication request's result returns, would get invoked with the captured credentials.WebAuthProvider.References
Testing
Add tests for the serializing and deserializing logic.
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors