Add -Encoding parameter to MemoryStream string functions (#21)#22
Merged
Add -Encoding parameter to MemoryStream string functions (#21)#22
Conversation
…21) - Add -Encoding parameter to ConvertFrom-MemoryStreamToString - Add -Encoding parameter to ConvertFrom-MemoryStreamToSecureString - Pass -Encoding through in ConvertFrom-MemoryStream for consistency - Update tests to use correct encoding when creating streams - Update documentation and CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
-Encodingparameter toConvertFrom-MemoryStreamToStringandConvertFrom-MemoryStreamToSecureStringfunctions, resolving the inconsistency where these functions hardcoded UTF-8 encoding while other similar functions in the module support encoding selection.Changes
New Features
-Encodingparameter toConvertFrom-MemoryStreamToString-Encodingparameter toConvertFrom-MemoryStreamToSecureStringUTF8for backward compatibilityFixed
ConvertFrom-MemoryStreamnow correctly passes-EncodingtoConvertFrom-MemoryStreamToStringfor consistent behavior across the moduleTests
ConvertFrom-MemoryStreamtests to create streams with correct encodingDocumentation
Example
Closes #21