Skip to content

Conversation

@andyshinn
Copy link
Collaborator

No description provided.

@andyshinn andyshinn requested a review from Copilot September 13, 2025 04:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches the logging system from Promtail to Alloy for collecting and processing logs from the Bridger application. The change modernizes the logging pipeline while maintaining compatibility with Loki for log storage.

  • Replaces Promtail with Grafana Alloy for log collection and processing
  • Adds new Alloy configuration files for both Docker and systemd journal-based deployments
  • Updates Grafana dashboard and datasource configurations to support the new logging setup

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
config/quadlet/alloy.container New container configuration for running Alloy in systemd
config/alloy/config-journal.alloy Alloy configuration for collecting logs from systemd journal
config/alloy/config-docker.alloy Alloy configuration for collecting logs from Docker containers
config/deploy.sh Updated deployment script to copy Alloy configuration files
compose.yaml Replaced Promtail service with Alloy service and updated volume mounts
config/grafana/provisioning/datasources/grafana-datasources.yaml Made Loki datasource editable
config/grafana/provisioning/dashboards/file-dashboards.yaml New dashboard provisioning configuration
config/grafana/dashboards/updated/Bridger-1757731649448.json New Grafana dashboard for Bridger logs
bridger/gateway.py Added command-line interface for MQTT gateway user management

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +6 to +7
loki.relabel "journal_labels" {
forward_to = []
Copy link

Copilot AI Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The forward_to parameter is set to an empty array but should reference the next component in the pipeline. This will cause the relabel component to drop all data instead of forwarding it to the processing stage.

Copilot uses AI. Check for mistakes.
Comment on lines +16 to +17
loki.relabel "docker_labels" {
forward_to = []
Copy link

Copilot AI Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The forward_to parameter is set to an empty array but should reference the next component in the pipeline. This will cause the relabel component to drop all data instead of forwarding it to the processing stage.

Copilot uses AI. Check for mistakes.
andyshinn and others added 2 commits September 12, 2025 23:17
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants