feat: adds AuraMinterOwner #428
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phijfry
reviewed
Nov 10, 2025
contracts/core/AuraMinterOwner.sol
Outdated
|
|
||
| /// @notice Maximum total AURA that can be minted through this contract (9 million with 18 decimals) | ||
| /// @dev This represents the absolute cap across all epochs (3 years * 3M per year) | ||
| uint256 public constant MAX_TOTAL_CAP = 9_000_000 * 1e18; |
Contributor
There was a problem hiding this comment.
We don't need to cap the total amount mineable, we just want to cap that only 3M gets minted every 52 weeks.
contracts/core/AuraMinterOwner.sol
Outdated
| uint256 currentEpochCap = currentEpoch * EPOCH_CAP; | ||
| uint256 totalAfterMinted = totalMinted + _amount; | ||
|
|
||
| require(totalAfterMinted <= currentEpochCap, "Exceeds epoch cap"); |
Contributor
There was a problem hiding this comment.
This logic allows for carry over, so for example if I don't mint anything in the first year the second year I can mint 6M. The preferred logic is that inflation is capped per 52 week period. So instead we should make sure that only 3M can be minted per epoch.
0xahtle7
force-pushed
the
feat/AuraMinterOwner
branch
from
1afd4a1 to
0725b22
Compare
Contributor
Author
|
no need anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds aura minter owner , allows DAO to mint a max amount of 3m Aura tokens per year during the following 3 years.