Imported GetTemp() and other things.#10
Open
JoelMon wants to merge 2 commits intoaudricd:masterfrom
JoelMon:gettemp-improvement
Open
Imported GetTemp() and other things.#10JoelMon wants to merge 2 commits intoaudricd:masterfrom JoelMon:gettemp-improvement
JoelMon wants to merge 2 commits intoaudricd:masterfrom
JoelMon:gettemp-improvement
Conversation
Made GetTemp() more robust by allowing it to handle more than one adapter, not only adapter 0. Moved the GetTemp() to the top of the source code to easily find it instead of having functions littered throughout the code. Added docstring to GetTemp(). Also moved the title and version of the application into a constant and moved it to the top of the source file to make it easy to edit. Made other minor PEP8 style edits.
Owner
|
I dont know about this one. Ill do my version first (tonight, most likely) and see whats hapenning. |
Owner
|
hold it dont close it yet! now that my code is clean I can work on implementing this and it looks good! just cant merge literally because it would bring back old code that Ive cleaned but the function gettemp is good! will do that later during the day. |
Owner
|
i got your code and adapted it to the new version, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made GetTemp() more robust by allowing it to handle more than one adapter, not only adapter 0. Moved the GetTemp() to the top of the source code to easily find it instead of having functions littered throughout the code. Added docstring to GetTemp(). Also moved the title and version of the application into a constant and moved it to the top of the source file to make it easy to edit. Made other minor PEP8 style edits.
UPDATE: Meant to say Improved GetTemp() in the title.