Conversation
…or Arian. Next pull request i will have all tested all the commands in vm.
WannabeMO
requested review from
Aw1221,
Kristoffer-August,
MrLoverZ and
audio-engineer
as code owners
MrLoverZ
approved these changes
May 22, 2025
Collaborator
MrLoverZ
left a comment
MrLoverZ
left a comment
There was a problem hiding this comment.
Didnt look through it, Mo had a gun to my head in teams to accept this.
Aw1221
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just the file and a few tests for the VM that actually work.
I left the conditional tests inside vm_test.c for Arian to work on.
My next task is to make the rest of the VM testing :-)