Conversation
- Add unit tests for parseEnvArg(), parseEnvFile(), validateEnvVarName() - Add tests for SENSITIVE_PATTERNS and getReservedEnvNames() - Add tests for --env flag precedence over --env-file - Add tests for sensitive pattern warnings - Create secrets.test.ts with tests for parseKeyValue(), isValidSecretKey() - Add tests for secretsSetCommand, secretsListCommand, secretsDeleteCommand - Export helper functions for direct unit testing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
emilioacc
deleted the
emilio/atxp-1436-add-missing-tests-for-paas-features-env-vars-secrets
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseEnvArg(),parseEnvFile(),validateEnvVarName()SENSITIVE_PATTERNSandgetReservedEnvNames()--envflag precedence over--env-filesecrets.test.tswith tests forparseKeyValue(),isValidSecretKey()secretsSetCommand,secretsListCommand,secretsDeleteCommandTest plan
Closes ATXP-1436 (partial - CLI side)
🤖 Generated with Claude Code