Skip to content

Comments

Return Result<>#10

Merged
atsyplenkov merged 13 commits intomasterfrom
add-result
Apr 29, 2025
Merged

Return Result<>#10
atsyplenkov merged 13 commits intomasterfrom
add-result

Conversation

@atsyplenkov
Copy link
Owner

This PR introduces idiomatic Result<> or Option<> as a return values for all Cell:: methods

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.64039% with 19 lines in your changes missing coverage. Please review.

Project coverage is 95.25%. Comparing base (4b2c6f4) to head (67b2fba).

Files with missing lines Patch % Lines
src/utils.rs 60.00% 12 Missing ⚠️
src/errors.rs 0.00% 6 Missing ⚠️
src/cells.rs 97.36% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   96.57%   95.25%   -1.33%     
==========================================
  Files           9       10       +1     
  Lines         672      779     +107     
==========================================
+ Hits          649      742      +93     
- Misses         23       37      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atsyplenkov atsyplenkov merged commit e4df514 into master Apr 29, 2025
10 checks passed
@atsyplenkov atsyplenkov deleted the add-result branch April 29, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants