Multi clipboard format support for Windows #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atotto
requested changes
Sep 20, 2018
Owner
atotto
left a comment
atotto
left a comment
There was a problem hiding this comment.
Thank you for your PR.
Please fix package path.
We must consider linux and darwin platform..
| "flag" | ||
| "fmt" | ||
| "github.com/kiennq/clipboard" | ||
| "io/ioutil" |
Owner
There was a problem hiding this comment.
please use github.com/atotto/clipboard
| @@ -1,14 +1,12 @@ | |||
| package clipboard_test | |||
| package clipboard | |||
|
|
||
| func TestCopyAndPaste(t *testing.T) { | ||
| expected := "日本語" | ||
| expected := "日本語\n" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 4 new interface function for clipboard package:
func ReadAllWithFormat(cf uintptr) (string, error)
func WriteAllWithFormat(text string, cf uintptr) error
func ClearClipboard() error
func getClipboardFormat(_ string)
With those, we can set and get multiple data type from clipboard.
One example is in Windows, we can set HTML clipboard and text clipboard simultaneously, application can choose to render which data depends on its needs. The newly add utility goclip is using the new interface to implement copy and paste multiple clipboard data type too.
Please refer to this https://msdn.microsoft.com/en-us/library/windows/desktop/ms649015(v=vs.85).aspx