replace browserify-incremental w/rebundler #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browserify-incremental doesn’t work with multiple bundles compiled at the same time. This makes it very unreliable and can produce very hard to trace errors in client-side code. This uses rebundler instead, which, as long as it’s given the `persistKey` option, doesn’t have the same problem.
Contributor
Author
|
@atomify/collaborators anyone mind reviewing this for me? |
naboo140593
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browserify-incremental doesn’t work with multiple bundles compiled at
the same time. This makes it very unreliable and can produce very hard
to trace errors in client-side code. This uses rebundler instead, which,
as long as it’s given the
persistKeyoption, doesn’t have the sameproblem.
This isn't a breaking change, and technically just changes internal APIs. We could release this as a patch version.