Conversation
| canvas_api_domain: "$Canvas.api.domain", | ||
| customer_caliper_endpoint_url: "$Caliper.url", | ||
| canvas_course_section_ids: "$Canvas.course.sectionIds", | ||
| canvas_term_start_at: "$Canvas.term.startAt",, |
There was a problem hiding this comment.
Lint/Syntax: unexpected token tCOMMA
| # def self.from_canvas_lti(event, params) | ||
|
|
||
| # event.group = Caliper::Entities::LIS::CourseSection.new( | ||
| # id: "https://#{params[:custom_canvas_api_domain]}/courses/#{params[:custom_canvas_course_id]}/sections/#{params[:custom_canvas_section_id]}", |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [151/120]
| ) | ||
| end | ||
|
|
||
| #return from_canvas_lti(event, params) if params[:custom_canvas_api_domain].present? |
There was a problem hiding this comment.
Layout/LeadingCommentSpace: Missing space after #.
| actor: @actor, | ||
| action: Caliper::Actions::USED, | ||
| edApp: @ed_app, | ||
| eventTime: event_time |
There was a problem hiding this comment.
Style/TrailingCommaInArguments: Put a comma after the last parameter of a multiline method call.
| requestor = Caliper::Request::HttpRequestor.new({ | ||
| 'host' => "http://learncaliper.herokuapp.com/api/consumer/events/1ebb1f70-5e82-0137-e4ac-4a8f9eeae0c8", | ||
| 'auth_token' => "1ebb1f70-5e82-0137-e4ac-4a8f9eeae0c8", | ||
| }) |
There was a problem hiding this comment.
Layout/IndentHash: Indent the right brace the same as the first position after the preceding left parenthesis.
| sensor = Caliper::Sensor.new('https://www.atomicjolt.com/sensors/1', options) | ||
| requestor = Caliper::Request::HttpRequestor.new({ | ||
| 'host' => "http://learncaliper.herokuapp.com/api/consumer/events/1ebb1f70-5e82-0137-e4ac-4a8f9eeae0c8", | ||
| 'auth_token' => "1ebb1f70-5e82-0137-e4ac-4a8f9eeae0c8", |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| options = Caliper::Options.new | ||
| sensor = Caliper::Sensor.new('https://www.atomicjolt.com/sensors/1', options) | ||
| requestor = Caliper::Request::HttpRequestor.new({ | ||
| 'host' => "http://learncaliper.herokuapp.com/api/consumer/events/1ebb1f70-5e82-0137-e4ac-4a8f9eeae0c8", |
There was a problem hiding this comment.
Layout/IndentHash: Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| params: params, | ||
| ) | ||
| options = Caliper::Options.new | ||
| sensor = Caliper::Sensor.new('https://www.atomicjolt.com/sensors/1', options) |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Gemfile.lock
Outdated
|
|
||
| BUNDLED WITH | ||
| 1.17.3 | ||
| 2.0.1 |
There was a problem hiding this comment.
Need to stick with 1.17.3 for the time being.
| @user = user | ||
|
|
||
| @actor = Caliper::Entities::Agent::Person.new( | ||
| id: "#{@application_instance.domain}/users/#{@user.id}", |
There was a problem hiding this comment.
Probably need to generate a different user id and include the sis id in the actor
3 participants
No description provided.