This repository was archived by the owner on Aug 12, 2019. It is now read-only.
fix accessibility warnings #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Not sure how hard it would be to add accessibility to the CI tests or whether we should do it. That would be a broader discussion across Atom I suspect. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using electron/devtron#87 I started going through Atom to find places that generated Accessibility Warnings/Errors.
Report Screenshot
Note the "contrast ratio" warnings are likely Theme-specific (I used the atom-dark theme).
PS: Any thoughts on whether CI audit tests should be sprinkled in as fixes are made to the various repositories?