Parse codes such as G00 X00Y00 (no space between axes)#6
Open
PtD wants to merge 1 commit intoatom-bomb:masterfrom
Open
Parse codes such as G00 X00Y00 (no space between axes)#6PtD wants to merge 1 commit intoatom-bomb:masterfrom
PtD wants to merge 1 commit intoatom-bomb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The G-code parser fails to detect additional axes if there's no space between them. For example,
G00 X0.123Y0.456
will only consider the X coordinate and will ignore the Y coordinate (the error remains hidden by atof specifics).
With this change, it will also cover cases like the one above.