-
Notifications
You must be signed in to change notification settings - Fork 2
Update local development instructions in README #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b4ca773 to
59a6fcb
Compare
|
Did you install this on linux or on macOS? Also i think the create database isn't correct. Also the environment variables are saved in .env which is loaded by |
| * heroku cli installed | ||
| * `brew install heroku` | ||
| * `brew install postgres` | ||
| * `pg_ctl start -D /usr/local/var/postgres` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the previous version not work on your machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope
mbp-IT002597:~ ethomas$ pg_ctl --version
pg_ctl (PostgreSQL) 10.3
mbp-IT002597:~ ethomas$ pg_ctl --help | head -10
pg_ctl is a utility to initialize, start, stop, or control a PostgreSQL server.
Usage:
pg_ctl init[db] [-D DATADIR] [-s] [-o OPTIONS]
pg_ctl start [-D DATADIR] [-l FILENAME] [-W] [-t SECS] [-s]
[-o OPTIONS] [-p PATH] [-c]
pg_ctl stop [-D DATADIR] [-m SHUTDOWN-MODE] [-W] [-t SECS] [-s]
pg_ctl restart [-D DATADIR] [-m SHUTDOWN-MODE] [-W] [-t SECS] [-s]
[-o OPTIONS] [-c]
pg_ctl reload [-D DATADIR] [-s]
I tried checking the pg_ctl release notes to see if something changed. Couldn't find anything. But putting the optional args before start resulted in an error for me
| * create database | ||
| * `psql -d postgres -c "create database cerealnotes_test"` | ||
| * Refer to `migrations/README.md` to create relevant database tables | ||
| * export environment variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you used heroku local you wouldn't need to do this
| export PORT=8000 | ||
| ``` | ||
| * run the app | ||
| * `go build && ./cerealnotes` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this instead of go install && heroku local?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to avoid heroku
| * `go build && ./cerealnotes` | ||
|
|
||
| ## Heroku | ||
| * heroku cli installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be installed to run locally
|
|
closing in favor of #39 |
No description provided.