Skip to content

Conversation

@jakejohns
Copy link

Updates for php8.

  • phpunit 9
  • avoid dynamic properties (i think tables/instances was just a mistake)
  • php8.1 PDO returns ints as ints, not strings. This just casts actual results to strings. Its hacky, but it wasnt testing type reality anyway.

Removes deprecation notice for dynamic property creation
phpunit.xml.dist Outdated
</whitelist>
</filter>
<?xml version="1.0"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="phpunit.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with the allowed versions in the Composer configuration, 7 and 9.

The local schema file can be used instead:

xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"

composer.json Outdated
"atlas/testing": "~1.0",
"pds/skeleton": "~1.0",
"phpunit/phpunit": "~7.0"
"phpunit/phpunit": "~7.0 || ~9.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants