Change ART::Route#defaults and matched route parameters return type to ART::Parameters
#652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blacksmoke16
added
component:routing
kind:enhancement
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (98.48%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.
📢 Thoughts on this report? Let us know! |
PallasAthenaie
pushed a commit
to athena-framework/framework
that referenced
this pull request
Jan 2, 2026
… to `ART::Parameters` (athena-framework/athena#652) ## Context This PR changes the type used to represent a route's default values and parameters returned when a route is matched. The new return type is able to store any value, not just `String?`. This ultimately makes things a bit more flexible as more advanced info can be stored to power other downstream features. While the API is very similar, still marking this as a breaking change as some type restrictions may need updated depending on how they were used.
PallasAthenaie
pushed a commit
to athena-framework/routing
that referenced
this pull request
Jan 2, 2026
… to `ART::Parameters` (athena-framework/athena#652) ## Context This PR changes the type used to represent a route's default values and parameters returned when a route is matched. The new return type is able to store any value, not just `String?`. This ultimately makes things a bit more flexible as more advanced info can be stored to power other downstream features. While the API is very similar, still marking this as a breaking change as some type restrictions may need updated depending on how they were used.
Blacksmoke16
added a commit
that referenced
this pull request
Jan 3, 2026
## Context Follow up to #636 that makes use of #652 to store the `_action` directly within the route defaults. This removes the needs for an extra mapping layer from controller name to `ATH::Action`. I kept `_controller` as a means to more easily tell what controller action handled the request. ## Changelog - Refactor how the `ATH::Action` for a given request is resolved - Expose `ATH::ActionResolver` and interface
PallasAthenaie
pushed a commit
to athena-framework/framework
that referenced
this pull request
Jan 3, 2026
…a-framework/athena#653) ## Context Follow up to athena-framework/athena#636 that makes use of athena-framework/athena#652 to store the `_action` directly within the route defaults. This removes the needs for an extra mapping layer from controller name to `ATH::Action`. I kept `_controller` as a means to more easily tell what controller action handled the request. ## Changelog - Refactor how the `ATH::Action` for a given request is resolved - Expose `ATH::ActionResolver` and interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR changes the type used to represent a route's default values and parameters returned when a route is matched. The new return type is able to store any value, not just
String?. This ultimately makes things a bit more flexible as more advanced info can be stored to power other downstream features.While the API is very similar, still marking this as a breaking change as some type restrictions may need updated depending on how they were used.
Before merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title