Conversation
aleem1314
reviewed
Mar 9, 2023
x/ibctransfer/module.go
Outdated
| func (am AppModule) OnAcknowledgementPacket(ctx sdk.Context, packet types.Packet, acknowledgement []byte, relayer sdk.AccAddress) error { | ||
| return am.cosmosAppModule.OnAcknowledgementPacket(ctx, packet, acknowledgement, relayer) | ||
| } | ||
| // func (am AppModule) OnAcknowledgementPacket(ctx sdk.Context, packet types.Packet, acknowledgement []byte, relayer sdk.AccAddress) error { |
There was a problem hiding this comment.
I think we still need to implement these methods. Now they are in the separate type IBCModule.
* Make ganache listen on both IPv4 and IPv6 * Upgrade requirements * Additional fixes * Fix GitHub CI workflows 'Lint' and 'Golang CI'
faneaatiku
reviewed
Oct 26, 2023
| app.GetSubspace(disptypes.ModuleName), | ||
| ) | ||
| mockModule := ibcmock.NewAppModule(scopedIBCMockKeeper, &app.IBCKeeper.PortKeeper) | ||
| mockModule := ibcmock.NewAppModule(&app.IBCKeeper.PortKeeper) |
There was a problem hiding this comment.
Maybe I'm missing something but I don't quite understand why is the mock needed....
There was a problem hiding this comment.
@faneaatiku here is an explanation:
https://github.com/atheeshp/sifnode/blob/master/app/app.go#L308-L309
// NOTE: the IBC mock keeper and application module is used only for testing core IBC. Do
// note replicate if you do not need to test core IBC or light clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.