Open
Conversation
added 2 commits
April 26, 2021 11:22
…flects updated file formatting from Shields.io.
…CGI.escapeElement(url, %)'. Escapes only the percentage symbol to prevent HTTParty conflicts.
Author
|
Closed pending resolution of edge-case URL encoding mismatch. |
…o match Shield.io's RFC 3986 encoding.
Author
|
Reopened with issue resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gem is nonfunctional with Ruby 3.0.0 owing to deprecation and removal of
URI::Escapemodule, as per issue 6. Additionally, comparison asset files no longer match Shield.io output, so RSpec tests do not pass with previous versions of Ruby. New branch has:coverage-flat.svgandcoverage.svgwith like-for-like versions generated by Shield.io on 2021-04-26.URI::EscapewithERB::Util:url_encodeto suit RFC 3986 as per Shield.io.After these changes, RSpec tests now pass.