Skip to content

Conversation

@SukiCZ
Copy link
Contributor

@SukiCZ SukiCZ commented Feb 5, 2025

This improves coverage from 79% to 97%

@atbuy atbuy self-requested a review February 6, 2025 15:02
@atbuy
Copy link
Owner

atbuy commented Feb 6, 2025

Looks good, nice idea to add tests for multiple pil versions, but I think the tests are badly written from the start. I'll try to rewrite them when I find the time.

@SukiCZ
Copy link
Contributor Author

SukiCZ commented Feb 6, 2025

Do you have anything particular in mind?

I think they are fine and we can iterate from here. Maybe test_ean.py is getting lenghty and could be split to separate files.

@atbuy
Copy link
Owner

atbuy commented Feb 7, 2025

@SukiCZ I was thinking more like tests using classes. I think they are more readable and more explicit. I'll probably have time tomorrow to implement them. I'll open a PR.

Do you have anything particular in mind?

I think they are fine and we can iterate from here. Maybe test_ean.py is getting lenghty and could be split to separate files.

@SukiCZ
Copy link
Contributor Author

SukiCZ commented Feb 7, 2025

@atbuy You mean something like 201ce27 ? 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants