Translate reset types available for Server#56
Open
glorpen wants to merge 1 commit intoaszlig:masterfrom
Open
Conversation
Owner
|
Possibly related: #61 |
aszlig
requested changes
May 8, 2023
Owner
aszlig
left a comment
aszlig
left a comment
There was a problem hiding this comment.
Thanks, but as mentioned, I'm not sure whether it's a good idea to expose these aliases throughout the Python API. What would be the benefit instead of using the actual upstream API values?
| self._update_status() | ||
| return self._reset_types | ||
|
|
||
| return tuple(key for key, value in self._modes.items() if value in self._reset_types) |
Owner
There was a problem hiding this comment.
This is an API change and rather than silently change its type and values, we should instead either opt for a deprecation process or wait for the next major release.
Comment on lines
+8
to
+13
| _modes = { | ||
| 'manual': 'man', | ||
| 'hard': 'hw', | ||
| 'soft': 'sw', | ||
| 'power': 'power', | ||
| } |
Owner
There was a problem hiding this comment.
I consider this to be an error that I introduced and rather than exposing this translation table further (and thus making it harder to get rid of), I'd instead remove it in the next major version and just use the values documented in the upstream API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently allowed reset types for Server are returned to user in raw form (as in Hetzner api), but when programmatically requesting reset, same types are required to be translated.
Translate names in both places to be consistent.
User code that relies on raw reset names will break.