use reset_types func for reset type support#55
Open
acjohnson wants to merge 2 commits intoaszlig:masterfrom
Open
use reset_types func for reset type support#55acjohnson wants to merge 2 commits intoaszlig:masterfrom
acjohnson wants to merge 2 commits intoaszlig:masterfrom
Conversation
Contributor
Author
|
Also this preserves the default functionality of your tool for servers that already support the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took another look at this and I can't for the life of me see why this wouldn't be a good solution to ensure the correct reset type is being used. This does a GET on
/resetwhich does the mapping for you and uses the completely unusedreset_typesfunction that you've already written.