-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: update meetings.json and newsrooom_videos.json #4918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #4918
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughNew video entries are appended to the newsroom videos configuration file. Each entry includes metadata such as image URL, title, description, and video ID. No existing entries are modified or removed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4918 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 796 796
Branches 146 146
=========================================
Hits 796 796 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4918--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @config/newsroom_videos.json:
- Line 88: Update the JSON "title" value that currently reads "AsyncAPI
Community WG Meeting , Tuesday Auguest 12th 2025" by correcting the typo
"Auguest" to "August" in the string (i.e., change "Auguest" → "August"); ensure
you update the same "title" field value where that exact string appears.
- Around line 94-108: Two entries share the same title and description but
different videoIds (7vvdmDVZPX0 and xD5smwg6az8); verify whether these are
separate recordings or a duplicate and then either remove the redundant entry or
disambiguate both records by updating the "title" and/or "description" to
indicate part numbers, timestamps, or different session context (e.g., "Part
1"/"Part 2" or "Recording A/B") and ensure the matching "image_url" and
"videoId" remain correct for whichever entry you keep or modify.
🧹 Nitpick comments (1)
config/newsroom_videos.json (1)
52-52: Consider decoding HTML entity.The title contains
'(HTML entity for apostrophe). If this data is sourced directly from YouTube's API, this may be expected. Otherwise, consider decoding HTML entities for cleaner display.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/newsroom_videos.json
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: cypress-run
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Lighthouse CI
🔇 Additional comments (3)
config/newsroom_videos.json (3)
31-37: LGTM!The trailing comma and first new entry are correctly formatted.
124-138: Verify multiple entries for June 17th, 2025.Three video entries reference "Tuesday June 17th 2025" (lines 124, 130, 136). While this could represent different working group meetings on the same date, please verify these are intentionally separate entries.
142-150: Verify duplicate entries for June 3rd, 2025.Two video entries reference "Tuesday June 3rd 2025" (lines 142, 148). Confirm these are distinct meetings.
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo in month name.
"Auguest" should be "August".
📝 Proposed fix
- "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025",
+ "title": "AsyncAPI Community WG Meeting , Tuesday August 12th 2025",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025", | |
| "title": "AsyncAPI Community WG Meeting , Tuesday August 12th 2025", |
🤖 Prompt for AI Agents
In @config/newsroom_videos.json at line 88, Update the JSON "title" value that
currently reads "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025" by
correcting the typo "Auguest" to "August" in the string (i.e., change "Auguest"
→ "August"); ensure you update the same "title" field value where that exact
string appears.
| "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1988.", | ||
| "videoId": "7vvdmDVZPX0" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/SaIPQaROWsc/hqdefault.jpg", | ||
| "title": "First Meeting of New Governance Board , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1989.", | ||
| "videoId": "SaIPQaROWsc" | ||
| }, | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/xD5smwg6az8/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025", | ||
| "description": "https://github.com/asyncapi/community/issues/1988.", | ||
| "videoId": "xD5smwg6az8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Fetch YouTube video metadata for the three video IDs
echo "=== Fetching YouTube video metadata ==="
echo ""
# Video 1: 7vvdmDVZPX0
echo "Video 1 (ID: 7vvdmDVZPX0):"
curl -s "https://www.youtube.com/oembed?url=https://www.youtube.com/watch?v=7vvdmDVZPX0&format=json" 2>/dev/null | jq -r 'if . then "Title: \(.title)\nAuthor: \(.author_name)\nThumbnail: \(.thumbnail_url)" else "Unable to fetch metadata" end'
echo ""
# Video 2: SaIPQaROWsc
echo "Video 2 (ID: SaIPQaROWsc):"
curl -s "https://www.youtube.com/oembed?url=https://www.youtube.com/watch?v=SaIPQaROWsc&format=json" 2>/dev/null | jq -r 'if . then "Title: \(.title)\nAuthor: \(.author_name)\nThumbnail: \(.thumbnail_url)" else "Unable to fetch metadata" end'
echo ""
# Video 3: xD5smwg6az8
echo "Video 3 (ID: xD5smwg6az8):"
curl -s "https://www.youtube.com/oembed?url=https://www.youtube.com/watch?v=xD5smwg6az8&format=json" 2>/dev/null | jq -r 'if . then "Title: \(.title)\nAuthor: \(.author_name)\nThumbnail: \(.thumbnail_url)" else "Unable to fetch metadata" end'Repository: asyncapi/website
Length of output: 608
Clarify or deduplicate entries with identical titles and descriptions.
Videos with IDs 7vvdmDVZPX0 and xD5smwg6az8 are distinct YouTube videos (different IDs and thumbnails), but both share the identical title "AsyncAPI Community WG Meeting , Tuesday July 29th 2025" and reference the same GitHub issue (#1988). Verify whether these represent different recordings of the same meeting or if this is a data entry error—if they're the same meeting, one entry should be removed or the titles should be differentiated.
🤖 Prompt for AI Agents
In @config/newsroom_videos.json around lines 94 - 108, Two entries share the
same title and description but different videoIds (7vvdmDVZPX0 and xD5smwg6az8);
verify whether these are separate recordings or a duplicate and then either
remove the redundant entry or disambiguate both records by updating the "title"
and/or "description" to indicate part numbers, timestamps, or different session
context (e.g., "Part 1"/"Part 2" or "Recording A/B") and ensure the matching
"image_url" and "videoId" remain correct for whichever entry you keep or modify.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.