-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: add slack-light color to tailwind config for button hover state #4916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
📝 WalkthroughWalkthroughThe Tailwind configuration's Slack color token is refactored from a single hex value to a color family object with DEFAULT and light variants, enabling the previously undefined Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4916 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 796 796
Branches 146 146
=========================================
Hits 796 796 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4916--asyncapi-website.netlify.app/ |
|
@ankushchk @asyncapi-bot @antoniogarrote @princerajpoot20 This issue was created by me #4907 , and I had already mentioned my intention to work on it. As clearly stated in the contribution guidelines, contributors must not start work or open a PR without prior approval. Opening a PR without approval goes against the project rules and creates unnecessary confusion and duplicate effort. Please make sure to follow the contribution guidelines in the future before submitting any PRs. For this reason, this PR should be closed. |
Description
The Slack button hover effect was failing because the color
slack-lightwas referenced in the component but not defined in tailwind.config.ts.This PR adds the missing
slack-lightcolor definition (#4A154B) to the configuration, restoring the intended hover behavior.Screenshots
Before:
Screen.Recording.2026-01-10.at.12.15.07.AM.mov
After:
Screen.Recording.2026-01-10.at.12.26.54.AM.mov
Related issue(s)
Fixes #4907
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.