Linux screenshot (scrot) performance improvement#89
Open
PatrickRogger wants to merge 1 commit intoasweigart:masterfrom
Open
Linux screenshot (scrot) performance improvement#89PatrickRogger wants to merge 1 commit intoasweigart:masterfrom
PatrickRogger wants to merge 1 commit intoasweigart:masterfrom
Conversation
|
@PatrickRogger This now has conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved performance for the pixel() function.
On a set of monitors, the screenshot was taking 400 ms, the solution to improve performance was instead of taking the screenshot of the entire screen and reading the pixel position, it was taking the screenshot already of a region and of only 1 pixel and so on improving the performance of the screenshot function by passing the region through the '-a' parameter of the 'scrot' command.