Skip to content

Completed #124 and other things#140

Open
thelabcat wants to merge 2 commits intoasweigart:masterfrom
thelabcat:master
Open

Completed #124 and other things#140
thelabcat wants to merge 2 commits intoasweigart:masterfrom
thelabcat:master

Conversation

@thelabcat
Copy link
Copy Markdown

  • Added docstring at beginning of module
  • Added support for KDE Spectacle
  • Addressed Replace which command to find if the system has gnome-screeshot #134, using shutil.which()
  • Removed most absolute variable reassignment
  • Replaced sys.platform() with platform.system() to simplify logic
  • Added PLATFORM variable to avoid checking platform more than once
  • Added LINUX_STDOUT_FILE variable for screenshot commands to write to stdout as a file path
  • Other miscellaneous absolute variable logic cleanup
  • Logic cleanup in _screenshot_linux()
  • Added docstring to _screenshot_linux()
  • _screenshot_linux() now uses stdout to avoid saving a temporary file
  • Removed documentation references to APT, as it is unique to Debian derivative distros.
  • Minor PEP-8 compliance improvements

- Added docstring at beginning of module
- Added support for KDE Spectacle
- Addressed asweigart#134, using shutil.which()
- Removed most absolute variable reassignment
- Replaced sys.platform() with platform.system() to simplify logic
- Added PLATFORM variable to avoid checking platform more than once
- Added LINUX_STDOUT_FILE variable for screenshot commands to write to stdout as a file path
- Other miscellaneous absolute variable logic cleanup
- Logic cleanup in _screenshot_linux()
- Added docstring to _screenshot_linux()
- _screenshot_linux() now uses stdout to avoid saving a temporary file
- Removed documentation references to APT, as it is unique to Debian derivative distros.
- Minor PEP-8 compliance improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant