Skip to content

Conversation

@pllim
Copy link
Member

@pllim pllim commented Jan 10, 2022

Goes with astropy/astropy#12705 to address astropy/astropy#12698 . Also see astropy/regions#392 .

@dhomeier , I cannot add you as "reviewer" but please review. Thanks!

Copy link

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've built the Astropy docs (without astropy/astropy#12705) against this and verified that the links are working without redirection, thanks!

@pllim pllim added this to the v1.7.0 milestone Jan 10, 2022
@pllim pllim merged commit a2c6adc into astropy:main Jan 10, 2022
@pllim pllim deleted the doc-mpl-base-url branch January 10, 2022 17:43
@pllim
Copy link
Member Author

pllim commented Jan 10, 2022

Do you need a new release?

@pllim
Copy link
Member Author

pllim commented Jan 10, 2022

astropy/astropy#12705 is for consistency's sake, so would be nice if you could give that a quick review as well. Thanks!

@dhomeier
Copy link

Do you need a new release?

Not sure, currently regions does not set a minver for this at all – @larrybradley , would there also be a way to use the dev version for the doc builds?

@larrybradley
Copy link
Member

@dhomeier I could update the tox build_docs environment, but that would only help for local doc builds. regions CI uses the RTD PR builder. Not sure if I can pin to a dev version for RTD. If this broken, then why not do a new release?

@pllim
Copy link
Member Author

pllim commented Jan 10, 2022

I could do a release. Just want to make sure there are no other stuff we need to fix beforehand.

@pllim
Copy link
Member Author

pllim commented Jan 10, 2022

If I don't hear back that I should wait in like 15 minutes, I'll cut a release. 😉

@pllim
Copy link
Member Author

pllim commented Jan 10, 2022

v1.7.0 is on PyPI now with this patch. Please let me know if you still have problems. Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants