Fix: Strip newline characters from dag_integrity_exceptions.txt entries#1802
Open
mohasoori wants to merge 2 commits intoastronomer:mainfrom
Open
Fix: Strip newline characters from dag_integrity_exceptions.txt entries#1802mohasoori wants to merge 2 commits intoastronomer:mainfrom
mohasoori wants to merge 2 commits intoastronomer:mainfrom
Conversation
The readlines module does not strip newline characters (\n) from the output, causing entries in dag_integrity_exceptions.txt to include them. This leads to incorrect comparisons and breaks the logic. By stripping the output, we ensure that DAG names are correctly matched as defined in dag_integrity_exceptions.txt. Example output before fix: Exceptions: ['# Add dag files to exempt from parse test below. ex: dags/<test-file>\n', 'dags/dag_example1\n', 'dags/dag_example2.py']
Used strip() to remove leading and trailing whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By stripping the output, we ensure that DAG names are correctly matched as defined in dag_integrity_exceptions.txt.
Example output before fix:
Exceptions: ['# Add dag files to exempt from parse test below. ex: dags/<test-file>\n', 'dags/dag_example1\n', 'dags/dag_example2.py']🎟 Issue(s)
🧪 Functional Testing
📸 Screenshots
After change:

📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft