feat: allow auth token-login flag value as filepath to avoid leaking token into shell history#1787
Open
jakedoublev wants to merge 3 commits intoastronomer:mainfrom
Open
feat: allow auth token-login flag value as filepath to avoid leaking token into shell history#1787jakedoublev wants to merge 3 commits intoastronomer:mainfrom
token-login flag value as filepath to avoid leaking token into shell history#1787jakedoublev wants to merge 3 commits intoastronomer:mainfrom
Conversation
… into shell history
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the functionality to take in a
token-loginflag value in the form of a file path containing the auth token. There is backwards compatibility with the existing state, but providing the token from a file location is a more secure way of authenticating the CLI via access token directly. Passing a token directly leaks the value into the shell history, which can make it available to other processes on a machine.The current state:
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
./astro login --token-login < token file path >📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft