godownloader refactor for allow using a GH Token, other improvements#1673
Open
godownloader refactor for allow using a GH Token, other improvements#1673
Conversation
- Allow passing a GitHub Token with -t to make Authenticated calls to the GH API with a much higher rate limit - Capture and parse the http status code in the github_release() method to properly log the status/message
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1673 +/- ##
=======================================
Coverage 86.35% 86.35%
=======================================
Files 116 116
Lines 16977 16977
=======================================
Hits 14660 14660
Misses 1394 1394
Partials 923 923 ☔ View full report in Codecov by Sentry. |
Author
|
Discussed this with @ashb a bit, gonna remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
releases/latestsince we never make a call togithub_release()without supplying a tag/version so that condition is never met.🧪 Functional Testing
📋 Checklist
I didn't both setting up a local astro env to test against because this is only a change the the downloader script, not actually changes to the CLI code. If I still need to do this, LMK and I'll get my env setup for it.
But because this script is what's returned from
curl -sSL install.astronomer.ioand in all of our CLI install docs, this should be reviewed closely!make testbefore taking out of draftmake lintbefore taking out of draft