PINF-305 - statsd and gitsync relay changes for git sync benchmarking#700
Open
rishkarajgi wants to merge 9 commits intomasterfrom
Open
PINF-305 - statsd and gitsync relay changes for git sync benchmarking#700rishkarajgi wants to merge 9 commits intomasterfrom
rishkarajgi wants to merge 9 commits intomasterfrom
Conversation
* add taint,tolleration and node selector support * add default values * add tests * fix tests * update tests * fix tests * Typo * Typo --------- Co-authored-by: Daniel Hoherd <danielh@astronomer.io>
…on and taints (#614) * add airflow config for dag server * add airflow config for gitsync relay * add support for termination grace period config * add termination grace period for gitsync config * update test cases
* fix workers scheduling ordering * update defaults tests for pod_template * update pod template workers tests * Update tests/chart/test_pod_template.py Co-authored-by: Daniel Hoherd <danielh@astronomer.io> --------- Co-authored-by: Daniel Hoherd <danielh@astronomer.io>
rishkarajgi
changed the title
Contributor
|
what are we trying to do in this PR |
pgvishnuram
reviewed
Feb 18, 2026
Comment on lines
+141
to
+148
| - name: METRICS_ENABLED | ||
| value: "{{ .Values.gitSyncRelay.metricsEnabled }}" | ||
| - name: STATSD_HOST | ||
| value: {{ tpl .Values.gitSyncRelay.statsdHost . }} | ||
| - name: STATSD_PORT | ||
| value: "{{ .Values.gitSyncRelay.statsdPort }}" | ||
| - name: DEBUG | ||
| value: "{{ .Values.gitSyncRelay.debug }}" |
Contributor
There was a problem hiding this comment.
This config spec says we have to allow passing external statsdHost . Assuming per deployment then i should route to our internal statsd host and expose the regex for the config
Contributor
There was a problem hiding this comment.
Also this whole config can be enclosed inside .Values.gitSyncRelay.metricsEnabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added changes to configs for statsd and gitsync relay for benchmarking metrics
Related Issues
Do not merge this PR until this text is replaced with links to related issues.
Testing
Do not merge this PR until this text is replaced with details about how these changes were tested.
Merging
Do not merge this PR until it lists which release branches this PR should be merged / cherry-picked into.