use of play-sound package with auto-player detection#2
Open
batje wants to merge 3 commits intoastronaughts:masterfrom
Open
use of play-sound package with auto-player detection#2batje wants to merge 3 commits intoastronaughts:masterfrom
batje wants to merge 3 commits intoastronaughts:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only issue has to do with the (default) player being used by the plugin. By upgrading to the play-sound package for audio, we gain player detection.
I also included an option for 2 default sounds: beep and fanfare, so users do not have to go out and search for sounds after installing the plugin.
And I built in some additional checks.