close bugs in issues #78 and #76. Use pragma once in headers #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sorry @rmathar closing this was a mistake. I tried to rebase your branch but as you offered a PR from master I guess I don't have rights to do that. |
Member
|
Reopening |
Member
|
...grunt... I cannot reopen.... I am really sorry for that. I tried a rebase because the astromati/master branch changed in the meantime, and I didn't want to bother you... next time I will ask you to do it.... :( |
Member
|
Ok, I've found my mistake ... I pushed my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes 2 typoes in the source code as detected in issues number 78 and 76.
It also uses the #pragma once in most headers (aside from the wcslib which has
apparently an external source) to avoid name polution of the CPP.