Skip to content

Conversation

@lesliech1004
Copy link

No description provided.

Added description for get_db_instrument.
Added an instruments section on api documentation
Added a code block example for ingesting publications.
@lesliech1004 lesliech1004 marked this pull request as draft November 27, 2025 01:12
lesliech1004 and others added 5 commits December 9, 2025 11:23
Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
@kelle
Copy link
Contributor

kelle commented Dec 9, 2025

The tests not passing are not related to this PR.

This is coming along nicely! When you're done, change from Draft to "Ready for review".

Search Object function
-------------------------
The **search_object** function allows you to search for astronomical objects in the database by name or identifier. It returns a list of matching sources along with their details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The **search_object** function allows you to search for astronomical objects in the database by name or identifier. It returns a list of matching sources along with their details.
The **search_object** method allows you to search for astronomical objects in the database by name or identifier. It returns a list of matching sources along with their details.

Inventory Search function
-------------------------
The **inventory_search** function returns all data for an object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The **inventory_search** function returns all data for an object
The **inventory_search** method returns all data for an object

Exploring the Schema
-------------------------
The database schema is accessible via the **db.metadata** attribute after loading the database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The database schema is accessible via the **db.metadata** attribute after loading the database.
The AstroDB Toolkit makes extensive use of the Astrodbkit package. Astrodbkit provides the Database class and useful methods for exploring the database.
The database schema is accessible via the **db.metadata** attribute after loading the database.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kelle
Copy link
Contributor

kelle commented Dec 9, 2025

Please make extensive use of the :py:func directive when referring to functions and :py:meth: to link to methods. For example,

:py:func:`find publication <astrodb_utils.publications.find_publication>`

will make an auto-magic link to the API documentation for the find_publication function.

Here's the relevant Sphinx documentation: https://www.sphinx-doc.org/en/master/usage/domains/python.html#target-specification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants