Ingest resolved children and close companions #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
instead of a dedicated function, I think this would be better as a flag in |
kelle
requested changes
Aug 19, 2025
Contributor
kelle
left a comment
kelle
left a comment
There was a problem hiding this comment.
This looks like a good start!
- when duplicates are found, please add a
logger.warningwith the potential duplicates found. - what happens when ingest_neighbors = True but ra/dec is not provided?
- add tests in test_source.py.
- ingesting a close companion with ingest_neighbors = False and it shouldn't work.
- ingest a close companion with ingest_neighbors = True and it should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper method in sources.py that ingests close companions and resolved children regardless of how close they are to each other. It first checks if the source preexists in the database, then ingests the source.
Closes issue #175