SIMBAD resolvable name helper method #189
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is awesome! As we discussed, please add some tests. (I converted this draft just so I know it's not ready yet.) |
Author
|
Wrote some tests for my helper method: simbad_resolvable_names. There are 2 cases where the name is resolvable in SIMBAD and 2 cases where the name is resolvable in SIMBAD. |
kelle
reviewed
Jul 21, 2025
Contributor
|
also add to the ingest_source function. |
Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
kelle
reviewed
Jul 25, 2025
kelle
reviewed
Jul 25, 2025
Contributor
|
Check out the functions in #89 which might be useful here. |
kelle
reviewed
Jul 25, 2025
kelle
reviewed
Jul 25, 2025
kelle
reviewed
Jul 25, 2025
Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper method in sources.py that checks if a source's name is resolvable in SIMBAD. If not, it returns alternative source names that ARE resolvable in SIMBAD.
Closes #33