Skip to content

Fix bug when creating a sqlite database via Felis #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kelle merged 1 commit into from
Dec 11, 2024
Merged

Fix bug when creating a sqlite database via Felis #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion astrodbkit/astrodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,8 @@ def create_database(connection_string, drop_tables=False, felis_schema=None):

# Schema handling for various database types
if connection_string.startswith("sqlite"):
db_name = connection_string.split("/")[-1]
# Get the full path to the file as otherwise the DB is only created in the working directory
db_name = connection_string.replace("sqlite:///", "")
with engine.begin() as conn:
conn.execute(text(f"ATTACH '{db_name}' AS {schema_name}"))
elif connection_string.startswith("postgres"):
Expand Down
Loading