Baluev method plus an notebook example#14
Open
nhuntwalker wants to merge 4 commits intoastroML:masterfrom
Open
Baluev method plus an notebook example#14nhuntwalker wants to merge 4 commits intoastroML:masterfrom
nhuntwalker wants to merge 4 commits intoastroML:masterfrom
Conversation
Member
|
Looks good. A couple things:
Thanks for putting this together! |
Member
|
Looks great, Nick! It looks like something has been changed in master, and there's now a merge conflict here. Can you merge your branch with master and fix the conflict? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Baluev 2008 method for calculating false alarm probabilities to lomb_scargle.py. Also added an ipynb for demonstrating the comparison between Baluev 2008 theoretical model and data from Gaussian white noise in the examples directory