Skip to content

Conversation

@aleberti
Copy link
Contributor

This PR implements the subtraction of unique pointings. It checks the pointings provided via the file, and then it checks if there are repeated Ra-Dec pairs. In that case, unique pairs are computed, so that the number of subtracted pointings is correct.

@aleberti
Copy link
Contributor Author

Behavior with the following pointings file:

#Time RA Dec
2025-03-26 01:15:53 276.08 51.42
2025-03-26 01:15:53 276.08 51.42
2025-03-26 00:25:01 267.632 54.7246
2025-03-26 00:45:01 271.35 52.8019
2025-03-26 01:05:01 276.959 53.9568
2025-03-26 01:25:01 276.954 48.9228
2025-03-26 01:45:01 281.796 51.643

and the command Tiling_Observations -skymap http://heasarc.gsfc.nasa.gov/FTP/fermi/data/gbm/triggers/2025/bn250313607/quicklook/glg_healpix_all_bn250313607.fit -time "2025-03-26 02:05:01" -o /home/mpp/Tests/tilepy -cfg /home/mpp/Software/grbcontroller/LSTTHController/conf/FollowupParameters_6_GBM.ini -eventName bn250313607 -tiles /home/mpp/Tests/tilepy/Pointings_observed_bn250313607.txt

Before the changes from this PR:

Subtracting pointings from /home/mpp/Tests/tilepy/Pointings_observed_bn250313607.txt
Coordinates ra: 276.08 dec: 51.42 Pgw: 0.3945193134958276 vs 0.3945193134958276
Coordinates ra: 276.08 dec: 51.42 Pgw: 0.0 vs 0.3945193134958276
Coordinates ra: 267.632 dec: 54.7246 Pgw: 0.04369796714430249 vs 0.04369796714430249
Coordinates ra: 271.35 dec: 52.8019 Pgw: 0.0771157338712796 vs 0.20112911648644355
Coordinates ra: 276.959 dec: 53.9568 Pgw: 0.10650235503152987 vs 0.30235965076738325
Coordinates ra: 276.954 dec: 48.9228 Pgw: 0.06439317765526986 vs 0.19635505967733863
Coordinates ra: 281.796 dec: 51.643 Pgw: 0.07159900890039808 vs 0.16515491355935172

After the changes from this PR:

Subtracting pointings from /home/mpp/Tests/tilepy/Pointings_observed_bn250313607.txt
Subtracting pointings from /home/mpp/Tests/tilepy/Pointings_observed_bn250313607.txt
Coordinates ra: 276.08 dec: 51.42 Pgw: 0.3945193134958276 vs 0.3945193134958276
Coordinates ra: 267.632 dec: 54.7246 Pgw: 0.04369796714430249 vs 0.04369796714430249
Coordinates ra: 271.35 dec: 52.8019 Pgw: 0.0771157338712796 vs 0.20112911648644355
Coordinates ra: 276.959 dec: 53.9568 Pgw: 0.10650235503152987 vs 0.30235965076738325
Coordinates ra: 276.954 dec: 48.9228 Pgw: 0.06439317765526986 vs 0.19635505967733863
Coordinates ra: 281.796 dec: 51.643 Pgw: 0.07159900890039808 vs 0.16515491355935172

@aleberti
Copy link
Contributor Author

It closes #19

@CLAassistant
Copy link

CLAassistant commented Sep 20, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ aleberti
❌ pre-commit-ci[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants