Add attestations for release artifacts and Docker images#2827
Open
shaanmajid wants to merge 3 commits intoastral-sh:mainfrom
Open
Add attestations for release artifacts and Docker images#2827shaanmajid wants to merge 3 commits intoastral-sh:mainfrom
shaanmajid wants to merge 3 commits intoastral-sh:mainfrom
Conversation
Contributor
Author
|
cc @woodruffw per astral-sh/ruff#23111 (comment) :^) |
Member
|
Thanks @shaanmajid, assigning myself! I should be able to review this tomorrow. |
2952c81 to
600839a
Compare
Contributor
Author
|
Rebased onto latest main to resolve a merge conflict. No rush, but ready for review whenever you get a chance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds GitHub artifact attestations (SLSA provenance) for release artifacts and Docker images.
Users will be able to verify artifacts with:
Test Plan
Tested end-to-end release and attestation verification on my fork.
Verify release artifacts:
gh release download 0.0.17 --repo shaanmajid/ty --pattern "ty-x86_64-unknown-linux-gnu.tar.gz" --dir /tmp gh attestation verify /tmp/ty-x86_64-unknown-linux-gnu.tar.gz --repo shaanmajid/tyVerify Docker images:
Notes
actions/attest-build-provenancewas preexisting indist-workspace.tomlbut unused, so the upgrade across major versions is safe.