-
Notifications
You must be signed in to change notification settings - Fork 9
Tab colors #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Tab colors #1
Conversation
This is a follow up to the previous accidental commit.
|
Thanks! I will look at this. I am still a github novice so please be patient with me as I figure out the best way to review and merge these updates. |
|
You're welcome. Oh yeah, I forgot this only modifies the source files used by I too am fairly new to GitHub, although I have worked with Git and GitLab before. |
|
That should be fine. I planned to move away from the minified versions anyway. |
|
In general I'm ok with the change. However, there are some specifics that I don't quite like. If you were to change all the saturation values to 30% instead of 50% and decrease the box shadow size to something like "inset 0 0 0.5em .3em hsl(0, 30%, 50%)" I think I would accept the pull request. I'm not sure if I'm supposed to close this pull request without merging or if you can make these additional changes here. |
|
I think you can leave it open. I will implement the changes later and check how it looks. |
|
FYI, I have added some information about contributing to this project here: You should read it before deciding to continue with this pull request. This request is violating the rule that says changes should be made based on the master branch but we can ignore that rule in this case since you submitted it before I wrote the rule. |
|
Sorry it's taking so long... |
|
This is still on my to-do list. 😄 |
This series transforms the default-looking buttons into colorful tabs.