Skip to content

Conversation

@vlk-charles
Copy link

This series transforms the default-looking buttons into colorful tabs.

@asteriskman7
Copy link
Owner

Thanks! I will look at this. I am still a github novice so please be patient with me as I figure out the best way to review and merge these updates.

@vlk-charles
Copy link
Author

You're welcome. Oh yeah, I forgot this only modifies the source files used by index_debug.html, not the "compressed" ones used by index.html.

I too am fairly new to GitHub, although I have worked with Git and GitLab before.

@asteriskman7
Copy link
Owner

That should be fine. I planned to move away from the minified versions anyway.

@asteriskman7
Copy link
Owner

In general I'm ok with the change. However, there are some specifics that I don't quite like. If you were to change all the saturation values to 30% instead of 50% and decrease the box shadow size to something like "inset 0 0 0.5em .3em hsl(0, 30%, 50%)" I think I would accept the pull request.

I'm not sure if I'm supposed to close this pull request without merging or if you can make these additional changes here.

@vlk-charles
Copy link
Author

I think you can leave it open. I will implement the changes later and check how it looks.

@asteriskman7
Copy link
Owner

FYI, I have added some information about contributing to this project here:
https://github.com/asteriskman7/dldtg/blob/master/CONTRIBUTING.md

You should read it before deciding to continue with this pull request. This request is violating the rule that says changes should be made based on the master branch but we can ignore that rule in this case since you submitted it before I wrote the rule.

@vlk-charles
Copy link
Author

Sorry it's taking so long...

@vlk-charles
Copy link
Author

This is still on my to-do list. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants