-
Notifications
You must be signed in to change notification settings - Fork 69
Redesign Guides #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lachlanjc
wants to merge
1
commit into
assemblymade:master
Choose a base branch
from
lachlanjc:newguides
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Redesign Guides #290
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,7 +33,7 @@ | |
|
|
||
| .caps { | ||
| text-transform: uppercase; | ||
| letter-spacing: 0.2px; | ||
| letter-spacing: 0.1em; | ||
| font-size: 1rem; | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,19 @@ | ||
| class GuidesController < ApplicationController | ||
|
|
||
| def index | ||
| @guide_groups = GuidesGroup.all | ||
| @guide_group = GuidesGroup.find_by_slug!(params.fetch(:group, 'platform')) | ||
| def faq | ||
| @article_list = FaqGroup.all | ||
| @article = FaqGroup.find_by_slug!(params.fetch(:group)) | ||
| @title = "FAQs" | ||
| @description = "Frequently asked questions about #{@article.name.downcase} on Assembly." | ||
| @show_toc = false | ||
| render :index | ||
| end | ||
|
|
||
| def guides | ||
| @article_list = GuidesGroup.all | ||
| @article = GuidesGroup.find_by_slug!(params.fetch(:group, "platform")) | ||
| @title = "Guides" | ||
| @description = "A guide about #{@article.name.downcase} on Assembly." | ||
| @show_toc = true | ||
| render :index | ||
| end | ||
| end | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,43 @@ | ||
| <% title @guide_group.name, 'Guides' %> | ||
| <% provide(:description, "Frequently asked questions about #{@guide_group.name.downcase} on Assembly.") %> | ||
|
|
||
| <!-- TODO Deprecate. Pages now use gray bg. (chrislloyd) --> | ||
| <style>body { background-color: white !important; }</style> | ||
|
|
||
| <%= render 'shared/navbar' %> | ||
|
|
||
| <%# cache FaqGroup.cache_key(@guide_group) do %> | ||
| <div class="container"> | ||
|
|
||
| <div class="border-bottom py3 mb4"> | ||
| <ol class="breadcrumb mb2"> | ||
| <li class="active">Guides</li> | ||
| <li></li> | ||
| </ol> | ||
| <h1 class="mt2 mb0"><%= @guide_group.name %></h1> | ||
| </div> | ||
|
|
||
| <div class="clearfix mxn4"> | ||
| <div class="md-col md-col-8 px4"> | ||
|
|
||
| <ul class="list-reset"> | ||
| <% @guide_group.questions.each do |question| %> | ||
| <li class="question"> | ||
| <%= link_to question[:name], anchor: question[:anchor] %> | ||
| </li> | ||
| <% end %> | ||
| </ul> | ||
|
|
||
| <hr class="border-bottom mt4 mb4"> | ||
|
|
||
| <%= @guide_group.body.html_safe %> | ||
|
|
||
| </div> | ||
|
|
||
| <div class="md-col md-col-4 px4"> | ||
| <ul class="list-reset"> | ||
| <% @guide_groups.each do |guide_group| %> | ||
| <li> | ||
| <a class="block gray-1 py1 <%= 'bold blue' if @guide_group.slug == guide_group.slug %>" href="<%= guides_path(guide_group) %>"><%= guide_group.name %></a> | ||
| </li> | ||
| <% end %> | ||
| </ul> | ||
| </div> | ||
|
|
||
| </div> | ||
| </div> | ||
| <%# end %> | ||
|
|
||
| <%= render 'shared/footer' %> | ||
| <% title @article.name, @title %> | ||
| <% provide(:description, @description) %> | ||
| <% provide(:body_class, "bg-white") %> | ||
|
|
||
| <%= render "shared/navbar" %> | ||
|
|
||
| <div class="container mt3"> | ||
| <section class="mt4 p3 right well"> | ||
| <h4 class="caps gray-2 center mt0 mb2">More <%= @title %></h4> | ||
| <ul class="list-reset mt2 mb0"> | ||
| <% @article_list.each do |article| %> | ||
| <li class="mt1"> | ||
| <span class="icon icon-chevron-right gray-3"></span> | ||
| <% @article_link = help_path(article) if @title == "FAQs" %> | ||
| <% @article_link = guides_path(article) if @title == "Guides" %> | ||
| <%= link_to article.name, @article_link.to_s, class: ("gray-1" + " bold blue" if @article.slug == article.slug) %> | ||
| </li> | ||
| <% end %> | ||
| </ul> | ||
| </section> | ||
|
|
||
| <article class="sm-col-11 md-col-8 left"> | ||
|
|
||
| <h2 class="mtn1 py2 border-bottom"><%= @title %>: <span class="regular"><%= @article.name %></span></h2> | ||
|
|
||
| <% if @show_toc == true %> | ||
| <h5 class="m0 py2 caps gray-2">In this guide:</h5> | ||
| <ul class="list-reset"> | ||
| <% @article.questions.each do |question| %> | ||
| <li> | ||
| <span class="icon icon-chevron-right gray-3"></span> | ||
| <%= link_to question[:name], anchor: question[:anchor] %> | ||
| </li> | ||
| <% end %> | ||
| </ul> | ||
| <% end %> | ||
|
|
||
| <%= @article.body.html_safe %> | ||
|
|
||
| </article> | ||
| </div> | ||
|
|
||
| <%= render "shared/footer" %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [92/80]