Skip to content

fixing issue 29 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
assaferan merged 2 commits into from
Jan 21, 2025
Merged

fixing issue 29 #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f70fe23
fixing issue 29
assaferan Jan 21, 2025
5ae2f5f
not allowing for N = 1 which causes issues
assaferan Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ModFrmGL2/ModSymA
Open in desktop
Submodule ModSymA updated 3 files
+344 −0 ModelsAndMaps.m
+0 −1 maps.m
+8 −18 subspace.m
6 changes: 3 additions & 3 deletions ModFrmGL2/Tests/AtkinLehner.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ procedure Test_AtkinLehner(numchecks : maxN := 15, maxk := 6)
end for;
end procedure;

procedure Test_IssueKoutsianas()
printf "Testing issue in mail from Koutsianas... ";
procedure Test_Issue30()
printf "Testing issue #30";
gens := [[1,3,12,3],[1,1,12,7],[1,3,0,3],[1,0,2,3]];
N := 16;
H_N := sub<GL(2,Integers(N)) | gens>;
Expand All @@ -27,4 +27,4 @@ procedure Test_IssueKoutsianas()

Test_AtkinLehner(5);

Test_IssueKoutsianas();
Test_Issue30();
15 changes: 15 additions & 0 deletions ModFrmGL2/Tests/Issue29.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
procedure Test_Issue29()
printf "Testing issue #29";
P<x,y,z,u,v,w> := ProjectiveSpace(Rationals(),5);
gens := [[4,0,0,3], [0,1,1,0], [2,0,0,2]];
N := 11;
H_N := sub<GL(2, Integers(N)) | gens>;
H := PSL2Subgroup(H_N);
M := ModularSymbols(H, 2, Rationals(), 0);
S := CuspidalSubspace(M);
XD10nred<[x]>, basisD10 := ModularCurve(H);
assert IsCurve(XD10nred);
assert not IsHyperelliptic(XD10nred);
end procedure;

Test_Issue29();
13 changes: 10 additions & 3 deletions ModFrmGL2/Tests/Shimura.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,18 @@ function Test_Shimura(N)
// mat_gens := [[-1,0,0,-1],[1,t,0,1]] cat [[a,0,0,1] : a in h_gens]
// cat [[1,0,0,d] : d in all_gens];
// gamma := PSL2Subgroup(sub<GL(2, Integers(N)) | mat_gens>);
gamma := GammaShimura(N, U, phi, H`subgroup, t);
gamma := GammaShimura(U, phi, H`subgroup, t);
// M := ModularSymbols(gamma, 2, Rationals(), 0);
M := ModularSymbols(gamma);
S := CuspidalSubspace(M);
D := NewformDecomposition(S);
// D := Decomposition(S, HeckeBound(S));
// D := NewformDecomposition(S);
D := Decomposition(S, HeckeBound(S));
return D, S;
end function;

num_times := 5;
max_N := 10;
for i in [1..num_times] do
N := Random(2, max_N);
D, S := Test_Shimura(N);
end for;
Loading