Skip to content

Change Texture2D::fill to be non-mutable #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asny merged 1 commit into from
Jun 14, 2025
Merged

Change Texture2D::fill to be non-mutable #549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/texture/texture2d.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ impl Texture2D {
cpu_texture: &CpuTexture,
data: &[T],
) -> Self {
let mut texture = Self::new_empty::<T>(
let texture = Self::new_empty::<T>(
context,
cpu_texture.width,
cpu_texture.height,
Expand Down Expand Up @@ -101,7 +101,7 @@ impl Texture2D {
/// Will panic if the length of the data does not correspond to the width, height and format specified at construction.
/// It is therefore necessary to create a new texture if the texture size or format has changed.
///
pub fn fill<T: TextureDataType>(&mut self, data: &[T]) {
pub fn fill<T: TextureDataType>(&self, data: &[T]) {
check_data_length::<T>(self.width, self.height, 1, self.data_byte_size, data.len());
self.bind();
let mut data = data.to_owned();
Expand Down
Loading