A scanmail flag creation added. to let the system scheduler know that message base shall be scanned. Feature is enabled by defining 'scanflag' variable in config.#175
Open
uncleeugene wants to merge 1 commit intoaskovpen:masterfrom
Conversation
In case any new messages were written, a flag file will be created upon quitting to let the system scheduler know that message base shall be scanned. Feature is enabled by defining 'scanflag' variable in config.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| return !info.IsDir() | ||
| } | ||
|
|
||
| func CreateFlagFile(filename string) error { |
There was a problem hiding this comment.
exported function CreateFlagFile should have comment or be unexported
Owner
There was a problem hiding this comment.
Please add comment and tests to function
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 56.72% 57.71% +0.99%
==========================================
Files 15 15
Lines 1428 1594 +166
==========================================
+ Hits 810 920 +110
- Misses 490 545 +55
- Partials 128 129 +1 ☔ View full report in Codecov by Sentry. |
askovpen
reviewed
Jan 30, 2025
|
|
||
| func CreateFlagFile(filename string) error { | ||
| if filename != "" { | ||
| _, err := os.Create(filename) |
Owner
There was a problem hiding this comment.
Please add check if directory exists and file not exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.