Change project_schema to use Option<&[usize]>#3
Closed
alamb wants to merge 2 commits intoaskalt:askalt/arc_immutablefrom
Closed
Change project_schema to use Option<&[usize]>#3alamb wants to merge 2 commits intoaskalt:askalt/arc_immutablefrom
alamb wants to merge 2 commits intoaskalt:askalt/arc_immutablefrom
Conversation
- Closes apache#19852 Improve performance of query planning and plan state re-set by making node clone cheap. - Store projection as `Option<Arc<[usize]>>` instead of `Option<Vec<usize>>` in `FilterExec`, `HashJoinExec`, `NestedLoopJoinExec`. - Store exprs as `Arc<[ProjectionExpr]>` instead of Vec in `ProjectionExprs`. - Store arced aggregation, filter, group by expressions within `AggregateExec`.
askalt
force-pushed
the
askalt/arc_immutable
branch
5 times, most recently
from
1e27378 to
2c0746c
Compare
Owner
|
Applied in the target PR, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test change to
ExecutionPlans less costly) apache/datafusion#19893To try and make the signature of
project_schemasimpler (not generic)