Update links to graphql client repository #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th1988
force-pushed
the
update-links-to-graphql-client
branch
from
ad26c50 to
7a44107
Compare
Generated by 🚫 Danger |
yuki24
approved these changes
Nov 2, 2024
Collaborator
yuki24
left a comment
yuki24
left a comment
There was a problem hiding this comment.
I had a question about the CHANGELOG entry, but overall 👍
CHANGELOG.md
Outdated
| @@ -1,5 +1,6 @@ | |||
| ### (Next) | |||
| * Your contribution here. | |||
| * Update graphql-client github repository links in README - [@th1988] | |||
Collaborator
Collaborator
There was a problem hiding this comment.
It's fine, but we do need to fix CI even if this is unrealated.
dblock
requested changes
Nov 2, 2024
Collaborator
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
Please make the CHANGELOG line like the others, with link to PR and your name, thanks!
We do need to fix CI, I know it's not failing because of this change, but I'd prefer we don't merge anything before that. Maybe you can help?
Collaborator
Collaborator
|
Rebase this please? |
th1988
force-pushed
the
update-links-to-graphql-client
branch
from
7a44107 to
bde6d9a
Compare
Contributor
Author
|
Done @dblock 🚀 |
dblock
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.